vibhatha commented on code in PR #40340: URL: https://github.com/apache/arrow/pull/40340#discussion_r1579094622
########## java/vector/src/test/java/org/apache/arrow/vector/TestVarCharViewVector.java: ########## Review Comment: > Do we have a test of overwriting an existing value? We should test all of overwriting a short string, overwriting a short string with a long string, overwriting a long string with a short string, overwriting a long string with a long string (but shorter) - no reallocation, and overwriting a long string with a longer string - needs a reallocation. (And we should be able to overwrite an element in the middle of the vector in all cases, this is what differentiates this vector from the regular string vector.) Good point. I will add some tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
