netthier opened a new pull request, #5690: URL: https://github.com/apache/arrow-rs/pull/5690
# Which issue does this PR close? <!-- We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123. --> Closes #5689. # What changes are included in this PR? <!-- There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR. --> This PR adds `Attribute::ContentDisposition`, `Attribute::ContentEncoding` and `Attribute::ContentLanguage` and implements them for the `http`, `aws`, `azure` and `gcp` clients. # Are there any user-facing changes? Yes, the new aforementioned variants. However, as the enum is marked `#[non_exhaustive]`, this shouldn't be a breaking change. <!-- If there are user-facing changes then we may require documentation to be updated before approving the PR. --> <!--- If there are any breaking changes to public APIs, please add the `breaking change` label. --> # Note I tried running the integration tests, but was unable to pass `gcs_test` and `azure_blob_test`. However, I got exactly the same failures on `master`. `s3_test` passed, though another test from the `aws` suite failed. I posted about this [on Discord](https://discord.com/channels/885562378132000778/885562378132000781/1233024373032751194) and would appreciate guidance or a fix to more thoroughly test this change. <details> <summary>Message text</summary> Is the `CONTRIBUTING.md` for object_store outdated? None of the tests complete fully successfully for me, even on master, seemingly related to missing options or environment variables. AWS tests seem to be missing `EC2_METADATA_ENDPOINT`, Azure the container name and GCP a bucket name and private key ID. Attempting to manually provide the container name in the case of Azure (I'm assuming `test-bucket` leads to a test failure in `azure_blob_test`: https://paste.debian.net/hidden/8b5a7f1f/ Manually providing the missing options for GCP (adding a `private_key_id` field to the JSON and setting the bucket name) still leads to some test failures: https://paste.debian.net/hidden/05fec244/ </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
