zanmato1984 commented on code in PR #41335:
URL: https://github.com/apache/arrow/pull/41335#discussion_r1579700801
##########
cpp/src/arrow/acero/query_context.cc:
##########
@@ -23,6 +23,36 @@ namespace arrow {
using arrow::internal::CpuInfo;
namespace acero {
+namespace internal {
+
+int64_t GetTempStackSizeFromEnvVar() {
+ auto maybe_env_value = arrow::internal::GetEnvVar(kTempStackSizeEnvVar);
+ if (!maybe_env_value.ok()) {
+ return kDefaultTempStackSize;
+ }
+ auto env_value = *std::move(maybe_env_value);
+ if (env_value.empty()) {
+ return kDefaultTempStackSize;
+ }
+
+ int64_t temp_stack_size = 0;
+ size_t length = 0;
+ bool exception = false;
+ try {
+ temp_stack_size = std::stoll(env_value.c_str(), &length);
+ } catch (const std::exception&) {
+ exception = true;
+ }
+ if (length != env_value.length() || exception || temp_stack_size <= 0) {
+ ARROW_LOG(WARNING) << "Invalid temp stack size provided in " <<
kTempStackSizeEnvVar
+ << ". Using default temp stack size: " <<
kDefaultTempStackSize;
+ return kDefaultTempStackSize;
+ }
+ return temp_stack_size;
Review Comment:
Given that: 1) a reasonable operator should use about 10s of KB - let's say
64KB; 2) a reasonable plan (not insanely complex) should contain no more than
100s of chained operators - let's give it 1024. Then a reasonable upper-bound
could be 64MB?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
