kou commented on code in PR #1762: URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580093034
########## dev/release/versions.env: ########## @@ -0,0 +1,30 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# The release as a whole has a date-based identifier. This is used to +# identify tags, branches, and so on. +RELEASE="2024.05.06" Review Comment: Hmm. It may be better that we omit preceding `0`: `2024.5.6` This is not a semantic versioning but semver https://pypi.org/project/semver/ can't parse `2024.05.06` format: ```console >>> import semver >>> semver.VersionInfo.parse('1.02.03') Traceback (most recent call last): File "<stdin>", line 1, in <module> File "/usr/lib/python3/dist-packages/semver.py", line 656, in parse raise ValueError("%s is not valid SemVer string" % version) ValueError: 1.02.03 is not valid SemVer string ``` (Sorry. The above transcript uses old semver, 2.10.2.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
