kou commented on code in PR #1762:
URL: https://github.com/apache/arrow-adbc/pull/1762#discussion_r1580662482
##########
dev/release/utils-prepare.sh:
##########
@@ -86,20 +106,20 @@ update_versions() {
git add "${desc_file}"
done
- sed -i.bak -E "s/^version = \".+\"/version = \"${version}\"/"
"${ADBC_DIR}/rust/Cargo.toml"
+ sed -i.bak -E "s/^version = \".+\"/version = \"${rust_version}\"/"
"${ADBC_DIR}/rust/Cargo.toml"
rm "${ADBC_DIR}/rust/Cargo.toml.bak"
git add "${ADBC_DIR}/rust/Cargo.toml"
if [ ${type} = "release" ]; then
pushd "${ADBC_DIR}/ci/linux-packages"
- rake version:update VERSION=${version}
+ rake version:update VERSION=${linux_version}
git add debian*/changelog yum/*.spec.in
popd
else
so_version() {
local -r version=$1
- local -r major_version=$(echo $version | sed -E -e
's/^([0-9]+)\.[0-9]+\.[0-9]+$/\1/')
- local -r minor_version=$(echo $version | sed -E -e
's/^[0-9]+\.([0-9]+)\.[0-9]+$/\1/')
+ local -r major_version=$(echo $linux_version | sed -E -e
's/^([0-9]+)\.[0-9]+\.[0-9]+$/\1/')
+ local -r minor_version=$(echo $linux_version | sed -E -e
's/^[0-9]+\.([0-9]+)\.[0-9]+$/\1/')
Review Comment:
Could you use `c_version` here? Our deb packages use SO version for `c/`
libraries.
```suggestion
local -r major_version=$(echo $c_version | sed -E -e
's/^([0-9]+)\.[0-9]+\.[0-9]+$/\1/')
local -r minor_version=$(echo $c_version | sed -E -e
's/^[0-9]+\.([0-9]+)\.[0-9]+$/\1/')
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
