tustvold commented on code in PR #5693:
URL: https://github.com/apache/arrow-rs/pull/5693#discussion_r1580864302
##########
object_store/src/aws/mod.rs:
##########
@@ -437,10 +437,16 @@ mod tests {
// Object tagging is not supported by S3 Express One Zone
if config.session_provider.is_none() {
- tagging(&integration, !config.disable_tagging, |p| {
- let client = Arc::clone(&integration.client);
- async move { client.get_object_tagging(&p).await }
- })
+ tagging(
Review Comment:
So one way you could avoid this would be to do something like
```
let integration = Arc::new(config.build().unwrap());
let config = &integration.client.config;
let test_not_exists = config.copy_if_not_exists.is_some();
let test_conditional_put = config.conditional_put.is_some();
put_get_delete_list(&*integration).await;
get_opts(&*integration).await;
list_uses_directories_correctly(&*integration).await;
list_with_delimiter(&*integration).await;
rename_and_copy(&*integration).await;
stream_get(&*integration).await;
multipart(&*integration, &*integration).await;
signing(&*integration).await;
s3_encryption(&*integration).await;
put_get_attributes(&*integration).await;
// Object tagging is not supported by S3 Express One Zone
if config.session_provider.is_none() {
tagging(Arc::clone(&integration) as _, !config.disable_tagging, |p| {
let client = Arc::clone(&integration.client);
async move { client.get_object_tagging(&p).await }
})
.await;
}
```
But I am not sure it is really cleaner.
FWIW I did try to push this but I don't seem to have the ability to edit
your PRs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
