jonkeane commented on code in PR #41372:
URL: https://github.com/apache/arrow/pull/41372#discussion_r1581582262
##########
r/src/compute-exec.cpp:
##########
@@ -411,10 +411,17 @@ std::shared_ptr<acero::ExecNode> ExecNode_Join(
const std::shared_ptr<acero::ExecNode>& right_data,
std::vector<std::string> left_keys, std::vector<std::string> right_keys,
std::vector<std::string> left_output, std::vector<std::string>
right_output,
- std::string output_suffix_for_left, std::string output_suffix_for_right) {
+ std::string output_suffix_for_left, std::string output_suffix_for_right,
+ bool na_matches) {
std::vector<arrow::FieldRef> left_refs, right_refs, left_out_refs,
right_out_refs;
+ std::vector<acero::JoinKeyCmp> key_cmps;
for (auto&& name : left_keys) {
left_refs.emplace_back(std::move(name));
+ // Populate key_cmps in this loop, one for each key
+ // Note that Acero supports having different values for each key, but dplyr
+ // only supports one value for all keys, so we're only going to support
that
+ // for now.
+ key_cmps.emplace_back(na_matches ? acero::JoinKeyCmp::IS :
acero::JoinKeyCmp::EQ);
Review Comment:
So many ways of swapping and passing and evaluating booleans 😂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
