birschick-bq commented on PR #1731: URL: https://github.com/apache/arrow-adbc/pull/1731#issuecomment-2080244619
> On the whole, I'm not excited about exposing two public and non-ADBC-specific functions from this assembly -- particularly without a stronger specification for them. Can we make them internal and then use InternalsVisibleTo? This is already being used in the C# Arrow implementation, so the build processes should support it. > > It would also be nice to eliminate the large number of nullability warnings by either removing the nullability annotations or by putting the code into a `#nullable` block. RE: nullability annotations I believe we need a separate ticket for this. It will require hundreds of small changes to mark current non-nullable types as nullable. I'll create a new issue for this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
