assignUser commented on code in PR #41403:
URL: https://github.com/apache/arrow/pull/41403#discussion_r1581719580
##########
dev/tasks/r/github.linux.versions.yml:
##########
@@ -30,7 +30,6 @@ jobs:
r_version:
# We test devel, release, and oldrel in regular CI.
# This is for older versions
- - "3.6"
- "4.0"
- "4.1"
Review Comment:
Should we add 4.2 as replacement for 3.6?
##########
ci/docker/linux-apt-r.dockerfile:
##########
@@ -35,7 +35,7 @@ ENV LANG=C.UTF-8
# Build R
# [1]
https://www.digitalocean.com/community/tutorials/how-to-install-r-on-ubuntu-18-04
# [2]
https://linuxize.com/post/how-to-install-r-on-ubuntu-18-04/#installing-r-packages-from-cran
-ARG r=3.6
Review Comment:
oO :D
##########
r/R/dplyr-funcs-type.R:
##########
@@ -140,7 +140,7 @@ register_bindings_type_cast <- function() {
fix.empty.names = TRUE,
stringsAsFactors = FALSE) {
# we need a specific value of stringsAsFactors because the default was
- # TRUE in R <= 3.6
+ # TRUE in R <= 3.6 and folks might still be cargoculting to stay in the
past.
Review Comment:
:grin:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
