Jefffrey commented on code in PR #5630:
URL: https://github.com/apache/arrow-rs/pull/5630#discussion_r1581793062
##########
parquet/src/arrow/schema/complex.rs:
##########
@@ -286,8 +286,8 @@ impl Visitor {
let map_key = &map_key_value.get_fields()[0];
let map_value = &map_key_value.get_fields()[1];
- if map_key.get_basic_info().repetition() != Repetition::REQUIRED {
- return Err(arrow_err!("Map keys must be required"));
+ if map_key.get_basic_info().repetition() == Repetition::REPEATED {
Review Comment:
Maybe we can add a comment here to explain why this check is relaxed?
e.g.
```rust
// Relax check which expects key to have repetition REQUIRED as there exists
// parquet writers and files which do not conform to this standard.
// This allows us to consume a broader range of existing files even if they
are
// out of spec.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
