baumgold commented on code in PR #504:
URL: https://github.com/apache/arrow-julia/pull/504#discussion_r1583960694


##########
test/runtests.jl:
##########
@@ -1042,5 +1042,25 @@ end
                 @test tbl.f[2] === Foo493(4, 5)
             end
         end
+
+        @testset "# 504" begin
+            struct Foo504
+                x::Int
+            end
+            
+            struct Bar504
+                a::Foo504
+            end
+
+            v = [Bar504(Foo504(i)) for i =1:3]
+            io = IOBuffer()
+            Arrow.write(io, v; file=false)
+            seekstart(io)
+            Arrow.append(io, v) # testing the compatility between the schema 
of the arrow Table, and the "schema" of v (using the fallback mechanism of 
Tables.jl)
+            seekstart(io)
+            t = Arrow.Table(io)
+            @test Arrow.Tables.rowcount(t) == 6
+        end
+

Review Comment:
   Fix formatting:
   
   ```suggestion
               struct Foo504
                   x::Int
               end
   
               struct Bar504
                   a::Foo504
               end
   
               v = [Bar504(Foo504(i)) for i = 1:3]
               io = IOBuffer()
               Arrow.write(io, v; file=false)
               seekstart(io)
               Arrow.append(io, v) # testing the compatility between the schema 
of the arrow Table, and the "schema" of v (using the fallback mechanism of 
Tables.jl)
               seekstart(io)
               t = Arrow.Table(io)
               @test Arrow.Tables.rowcount(t) == 6
           end
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to