ZhangHuiGui commented on code in PR #41419:
URL: https://github.com/apache/arrow/pull/41419#discussion_r1584064630
##########
cpp/src/arrow/compute/kernels/scalar_if_else.cc:
##########
@@ -1807,7 +1808,8 @@ struct CaseWhenFunctor<Type, enable_if_base_binary<Type>>
{
};
template <typename Type>
-struct CaseWhenFunctor<Type, enable_if_var_size_list<Type>> {
+struct CaseWhenFunctor<
+ Type, enable_if_t<is_base_list_type<Type>::value ||
is_list_view_type<Type>::value>> {
Review Comment:
1. Optimization for list-view types in current thread will be tracked in
https://github.com/apache/arrow/issues/41453 for optimize
2. The new commit includes case_when's list-view type benchmark for our
performance regression in the future
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
