zanmato1984 commented on PR #40237: URL: https://github.com/apache/arrow/pull/40237#issuecomment-2084654175
> The added test `TestConcurrentFillFromScalar` is failing on the emscripten build ([ursacomputing/crossbow/actions/runs/8871520273/job/24354620994](https://github.com/ursacomputing/crossbow/actions/runs/8871520273/job/24354620994)) > > From a quick look at the diff here, I _think_ it just needs some compile guards because the test requires threads to be available, like: > > ``` > #ifndef ARROW_ENABLE_THREADING > GTEST_SKIP() << "Test requires threading support"; > #endif > ``` Oops, didn't expect that coming. I'll file a quick fix. Thank you @jorisvandenbossche for locating the cause. One question though (I'm not familiar with emscripten): is emscripten's threading compilable but not runnable? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
