paleolimbot commented on code in PR #446:
URL: https://github.com/apache/arrow-nanoarrow/pull/446#discussion_r1584735735
##########
.github/workflows/verify.yaml:
##########
@@ -78,22 +78,17 @@ jobs:
- name: Cache Arrow C++ Build
id: cache-arrow-build
- uses: actions/cache@v3
+ uses: actions/cache@v4
with:
path: arrow
- key: arrow-${{ runner.os }}-6
+ # Bump the number at the end of this line to force a new Arrow C++
build
+ key: arrow-${{ runner.os }}-${{ runner.arch }}-1
- name: Build Arrow C++
if: steps.cache-arrow-build.outputs.cache-hit != 'true'
shell: bash
run: |
- curl
https://dlcdn.apache.org/arrow/arrow-14.0.2/apache-arrow-14.0.2.tar.gz | \
- tar -zxf -
- mkdir arrow-build && cd arrow-build
- cmake ../apache-arrow-14.0.2/cpp -DCMAKE_INSTALL_PREFIX=../arrow
- cmake --build .
- cmake --install . --prefix=../arrow ${{
matrix.config.extra_cmake_install }}
- cd ..
+ src/ci/scripts/build-arrow-cpp-minimal.sh 15.0.2 arrow
Review Comment:
It turned out there were a few changes required to make the job pass (the
actual change that fixes it is adding `runner.arch` to the cache key). I don't
mind doing this as a separate PR, although the Arrow version is not
particularly important here (we support back to 9.0.0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
