paleolimbot commented on PR #444:
URL: https://github.com/apache/arrow-nanoarrow/pull/444#issuecomment-2085292844

   > I have to say that I find the logic in the ArrayBuilder (sub)classes a bit 
harder to follow (e.g. compared to the current _c_array_from_iterable function)
   
   I agree that the original logic was clearer; however, the way it was 
implemented would never have scaled to support (say) `list<int32>`. I am not 
sure that the `ArrayBuilder` is the final answer to this but it is a step 
closer towards something that will scale to arbitrary recursive types/string 
arrays that need to be split into chunks because they contain more than 2 GB of 
text.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to