CurtHagenlocher commented on code in PR #1792:
URL: https://github.com/apache/arrow-adbc/pull/1792#discussion_r1585167722
##########
csharp/src/Apache.Arrow.Adbc/C/CAdbcDriverImporter.cs:
##########
@@ -113,12 +113,9 @@ public unsafe override AdbcDatabase
Open(IReadOnlyDictionary<string, string> par
{
caller.Call(_nativeDriver.DatabaseNew, ref nativeDatabase);
- if (parameters != null)
Review Comment:
parameters is defined as non-nullable. Of course, this doesn't prevent a
nullable-oblivious consumer from passing a null value. I don't have enough
personal experience with nullable to have any familiarity with best practices
-- comes from having to still support VS 2015, I suppose -- but maybe the right
thing to do is to throw an explicit ArgumentNullException in this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
