zanmato1984 commented on code in PR #41421:
URL: https://github.com/apache/arrow/pull/41421#discussion_r1585188127
##########
cpp/src/arrow/scalar.h:
##########
@@ -278,20 +283,32 @@ struct ARROW_EXPORT BaseBinaryScalar : public
internal::PrimitiveScalarBase {
struct ARROW_EXPORT BinaryScalar
: public BaseBinaryScalar,
private internal::ArraySpanFillFromScalarScratchSpace<BinaryScalar> {
- using BaseBinaryScalar::BaseBinaryScalar;
using TypeClass = BinaryType;
using ArraySpanFillFromScalarScratchSpace =
internal::ArraySpanFillFromScalarScratchSpace<BinaryScalar>;
+ explicit BinaryScalar(std::shared_ptr<DataType> type)
+ : BaseBinaryScalar(std::move(type)),
+ ArraySpanFillFromScalarScratchSpace(this->value) {}
+
+ BinaryScalar(std::shared_ptr<Buffer> value, std::shared_ptr<DataType> type)
+ : BaseBinaryScalar(std::move(value), std::move(type)),
+ ArraySpanFillFromScalarScratchSpace(this->value) {}
+
+ BinaryScalar(std::string s, std::shared_ptr<DataType> type)
+ : BaseBinaryScalar(std::move(s), std::move(type)),
+ ArraySpanFillFromScalarScratchSpace(this->value) {}
Review Comment:
Yeah, I agree. Thank you for the elaboration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
