alanstoate commented on PR #41477: URL: https://github.com/apache/arrow/pull/41477#issuecomment-2087419948
Hi @zeroshade I've had a go at adding these MemoryManager methods, just a few q's: - I've added all the copy/view methods in MemoryManager as slice versions I'm not sure if this is more than requested? - Should the existing copy/view methods in CPUMemoryManager call these slice versions with ```offset = 0``` & ```length = buf.size()``` to reduce code replication? - I should probably add a test for all of these, just wondering where that should live? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
