jorisvandenbossche commented on issue #41480: URL: https://github.com/apache/arrow/issues/41480#issuecomment-2088423982
> Does somebody know the history behind the "failure_permitted" logic? Does it still have its use today? The main thing I don't understand about our current setup is in which case you would actually encounter the situation of one the cython extension modules not being built without it erroring during the build. (maybe in the past things worked differently that required this logic?) Looking into when this logic was originally added (https://github.com/apache/arrow/pull/132 and https://github.com/apache/arrow/pull/194), it seems that at the time we were using `PARQUET_FOUND` to decide to build pyarrow with Parquet or not, so when something went wrong there, we were just silently not building `pyarrow.parquet`. But now we build this module opt-in based on `PYARROW_BUILD_PARQUET`, and in that case require that cmake finds Parquet lib and Arrow C++ is built with Parquet (`ARROW_PARQUET` is ON), and only then build the cython module. So my understanding is that any error of not having/finding libparquet as a failure in building the cython module will already fail loudly. Making this "failure_permitted" logic superfluous? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
