zeroshade commented on code in PR #40807:
URL: https://github.com/apache/arrow/pull/40807#discussion_r1586416413
##########
cpp/src/arrow/record_batch.cc:
##########
@@ -623,6 +667,16 @@ Status RecordBatch::ValidateFull() const {
return ValidateBatch(*this, /*full_validation=*/true);
}
+const std::shared_ptr<Device::SyncEvent>& RecordBatch::GetSyncEvent() const {
+ return null_sync_event_;
+}
+
+DeviceAllocationType RecordBatch::device_type() const {
+ return DeviceAllocationType::kCPU;
Review Comment:
because `device_type_` was added to the `SimpleRecordBatch` derived class
from RecordBatch, it's not in the base class. I didn't want to force
implementations to do it that way if they potentially could pull the
device_type from elsewhere.
So the default implementation just returns CPU, but @bkietz brought up a
good point https://github.com/apache/arrow/pull/40807#discussion_r1586298099
where it might make sense to just make this pure virtual instead of having a
default impl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
