alamb commented on a change in pull request #9388:
URL: https://github.com/apache/arrow/pull/9388#discussion_r579660483
##########
File path: rust/arrow/src/compute/kernels/concat.rs
##########
@@ -223,66 +223,36 @@ mod tests {
#[test]
fn test_concat_primitive_list_arrays() -> Result<()> {
- fn populate_list1(
- b: &mut ListBuilder<PrimitiveBuilder<Int64Type>>,
- ) -> Result<()> {
- b.values().append_value(-1)?;
- b.values().append_value(-1)?;
- b.values().append_value(2)?;
- b.values().append_null()?;
- b.values().append_null()?;
- b.append(true)?;
- b.append(true)?;
- b.append(false)?;
- b.values().append_value(10)?;
- b.append(true)?;
- Ok(())
- }
-
- fn populate_list2(
- b: &mut ListBuilder<PrimitiveBuilder<Int64Type>>,
- ) -> Result<()> {
- b.append(false)?;
- b.values().append_value(100)?;
- b.values().append_null()?;
- b.values().append_value(101)?;
- b.append(true)?;
- b.values().append_value(102)?;
- b.append(true)?;
- Ok(())
- }
-
- fn populate_list3(
- b: &mut ListBuilder<PrimitiveBuilder<Int64Type>>,
- ) -> Result<()> {
- b.values().append_value(1000)?;
- b.values().append_value(1001)?;
- b.append(true)?;
- Ok(())
- }
-
- let mut builder_in1 =
ListBuilder::new(PrimitiveArray::<Int64Type>::builder(0));
- let mut builder_in2 =
ListBuilder::new(PrimitiveArray::<Int64Type>::builder(0));
- let mut builder_in3 =
ListBuilder::new(PrimitiveArray::<Int64Type>::builder(0));
- populate_list1(&mut builder_in1)?;
- populate_list2(&mut builder_in2)?;
- populate_list3(&mut builder_in3)?;
-
- let mut builder_expected =
- ListBuilder::new(PrimitiveArray::<Int64Type>::builder(0));
- populate_list1(&mut builder_expected)?;
- populate_list2(&mut builder_expected)?;
- populate_list3(&mut builder_expected)?;
-
- let array_result = concat(&[
- &builder_in1.finish(),
- &builder_in2.finish(),
- &builder_in3.finish(),
- ])?;
+ let list1 = vec![
+ Some(vec![Some(-1), Some(-1), Some(2), None, None]),
Review comment:
This is much nicer, BTW
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
