alamb commented on code in PR #5710:
URL: https://github.com/apache/arrow-rs/pull/5710#discussion_r1588294849
##########
arrow-integration-testing/src/bin/arrow-json-integration-test.rs:
##########
@@ -40,7 +40,13 @@ struct Args {
arrow: String,
#[clap(short, long, help("Path to JSON file"))]
json: String,
- #[clap(value_enum, short, long, default_value_t = Mode::Validate,
help="Mode of integration testing tool")]
+ #[clap(
Review Comment:
apparently default_value_t (parsed value) is only available in Rust 1.70
I verified this is the right value (SCREAMING_SNAKE_CASE 🐍 ) like this:
```shell
cargo run --bin arrow-json-integration-test
```
##########
arrow-json/src/writer/encoder.rs:
##########
@@ -155,12 +155,21 @@ struct StructArrayEncoder<'a> {
explicit_nulls: bool,
}
+/// This API is only stable since 1.70 so can't use it when current MSRV is
lower
Review Comment:
same as above
##########
arrow-cast/src/parse.rs:
##########
@@ -435,11 +435,20 @@ impl Parser for Float64Type {
}
}
+/// This API is only stable since 1.70 so can't use it when current MSRV is
lower
Review Comment:
I simply copy/pasted from
[`is_some_and`](https://doc.rust-lang.org/std/option/enum.Option.html#method.is_some_and)
https://docs.rs/parquet/latest/src/parquet/file/metadata.rs.html#594-596
Otherwise clippy complains like
```
error: current MSRV (Minimum Supported Rust Version) is `1.62.0` but this
item is stable since `1.70.0`
--> arrow-json/src/writer/encoder.rs:163:56
|
163 | let is_null = field_encoder.nulls.as_ref().is_some_and(|n|
n.is_null(idx));
|
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
|
= help: for further information visit
https://rust-lang.github.io/rust-clippy/master/index.html#incompatible_msrv
= note: `-D clippy::incompatible-msrv` implied by `-D warnings`
= help: to override `-D warnings` add
`#[allow(clippy::incompatible_msrv)]`
```
##########
parquet/src/column/writer/mod.rs:
##########
@@ -1172,13 +1172,6 @@ fn compare_greater<T: ParquetValueType>(descr:
&ColumnDescriptor, a: &T, b: &T)
//
https://github.com/apache/parquet-mr/blob/master/parquet-column/src/main/java/org/apache/parquet/column/values/factory/DefaultV1ValuesWriterFactory.java
//
https://github.com/apache/parquet-mr/blob/master/parquet-column/src/main/java/org/apache/parquet/column/values/factory/DefaultV2ValuesWriterFactory.java
-/// Trait to define default encoding for types, including whether or not the
type
Review Comment:
unused
##########
parquet/src/encodings/encoding/mod.rs:
##########
@@ -47,12 +47,13 @@ pub trait Encoder<T: DataType>: Send {
/// identified by `valid_bits`.
///
/// Returns the number of non-null values encoded.
+ #[cfg(test)]
Review Comment:
only used in tests apparently
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
