emkornfield commented on code in PR #40594:
URL: https://github.com/apache/arrow/pull/40594#discussion_r1588519517
##########
cpp/src/parquet/column_writer.cc:
##########
@@ -1631,6 +1694,12 @@ class TypedColumnWriterImpl : public ColumnWriterImpl,
public TypedColumnWriter<
page_statistics_->UpdateSpaced(values, valid_bits, valid_bits_offset,
num_spaced_values, num_values, num_nulls);
}
+ if constexpr (std::is_same_v<T, ByteArray>) {
+ if (page_size_stats_builder_ != nullptr) {
+ page_size_stats_builder_->WriteValuesSpaced(values, valid_bits,
valid_bits_offset,
Review Comment:
I wonder if we could somehow gather this at a lower level (based on buffer
size of written values instead of having to handle Spaced values separately)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
