jorisvandenbossche commented on code in PR #41494:
URL: https://github.com/apache/arrow/pull/41494#discussion_r1588837384
##########
python/setup.py:
##########
@@ -270,23 +235,28 @@ def append_cmake_bool(value, varname):
cmake_options.append('-D{0}={1}'.format(
varname, 'on' if value else 'off'))
+ def maybe_append_cmake_bool(varname):
+ env_var = varname.replace("PYARROW_BUILD", "PYARROW_WITH")
+ if env_var in os.environ:
+ value = strtobool(os.environ.get(env_var))
+ append_cmake_bool(value, varname)
Review Comment:
I did that initially in a first version locally, but then moved it again to
setup.py to avoid the same problem with it being cached. But with you
suggestion above to use an AUTO default, then I can indeed move it back to the
cmake.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@arrow.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
