alamb commented on code in PR #5718:
URL: https://github.com/apache/arrow-rs/pull/5718#discussion_r1589970846
##########
arrow-array/src/array/byte_array.rs:
##########
@@ -232,6 +232,7 @@ impl<T: ByteArrayType> GenericByteArray<T> {
#[inline]
pub fn value_length(&self, i: usize) -> T::Offset {
let offsets = self.value_offsets();
+ assert!(i + 1 < offsets.len());
Review Comment:
I think this check is unecessary as `offsets[i + 1]` will panic if the
access is out of bounds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
