tustvold commented on code in PR #5718:
URL: https://github.com/apache/arrow-rs/pull/5718#discussion_r1590003775
##########
parquet/src/bloom_filter/mod.rs:
##########
@@ -179,7 +179,7 @@ fn num_of_bits_from_ndv_fpp(ndv: u64, fpp: f64) -> usize {
impl Sbbf {
/// Create a new [Sbbf] with given number of distinct values and false
positive probability.
- /// Will panic if `fpp` is greater than 1.0 or less than 0.0.
+ /// Will panic if `fpp` is greater than or equal to 1.0 or less than 0.0.
Review Comment:
```suggestion
/// Will return an error if `fpp` is greater than or equal to 1.0 or
less than 0.0.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
