ZhangHuiGui commented on PR #41380: URL: https://github.com/apache/arrow/pull/41380#issuecomment-2094710078
> Since this template is the catch-all implementation, removing any code that happens to not be used now is too risky: what if a new type is added to the list relying on this default implementation? In fact, the logic for processing `ArrayData` here is used to process the `DictionaryType` (already have independent CaseWhenFunctor logic for dictionary). The logic other than this type can be understood as processing the FixedWidth type (`CopyValues` is called), but in fact, the processing logic of all FixedWith type in `ScalarExecutor::Execute` can be used with preallocation's ArraySpan. So, the logic here is unused anymore unless we'll add a new fixed-length type without use preallocation logic? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
