mapleFU commented on code in PR #41546:
URL: https://github.com/apache/arrow/pull/41546#discussion_r1590767517
##########
cpp/src/parquet/encoding.cc:
##########
@@ -2803,15 +2806,15 @@ void DeltaLengthByteArrayEncoder<DType>::Put(const T*
src, int num_values) {
const int batch_size = std::min(kBatchSize, num_values - idx);
for (int j = 0; j < batch_size; ++j) {
const int32_t len = src[idx + j].len;
- if (AddWithOverflow(total_increment_size, len, &total_increment_size)) {
+ if (ARROW_PREDICT_FALSE(
+ AddWithOverflow(total_increment_size, len,
&total_increment_size))) {
throw ParquetException("excess expansion in DELTA_LENGTH_BYTE_ARRAY");
}
lengths[j] = len;
}
length_encoder_.Put(lengths.data(), batch_size);
}
-
- if (AddWithOverflow(encoded_size_, total_increment_size, &encoded_size_)) {
+ if (sink_.length() + total_increment_size >
std::numeric_limits<int32_t>::max()) {
Review Comment:
It doesn't matter since it's not in loop?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
