pitrou commented on code in PR #40998:
URL: https://github.com/apache/arrow/pull/40998#discussion_r1590947251
##########
cpp/src/arrow/compute/row/compare_internal.h:
##########
@@ -92,7 +98,8 @@ class ARROW_EXPORT KeyCompare {
static uint32_t NullUpdateColumnToRowImp_avx2(
uint32_t id_col, uint32_t num_rows_to_compare, const uint16_t*
sel_left_maybe_null,
const uint32_t* left_to_right_map, LightContext* ctx, const
KeyColumnArray& col,
- const RowTableImpl& rows, uint8_t* match_bytevector);
+ const RowTableImpl& rows, uint8_t* match_bytevector,
+ bool are_cols_in_encoding_order);
Review Comment:
Nit: output parameter (`uint8_t* match_bytevector`) should be last.
##########
cpp/src/arrow/compute/row/compare_internal.h:
##########
@@ -118,13 +125,11 @@ class ARROW_EXPORT KeyCompare {
static uint32_t AndByteVectors_avx2(uint32_t num_elements, uint8_t*
bytevector_A,
const uint8_t* bytevector_B);
- static uint32_t NullUpdateColumnToRow_avx2(bool use_selection, uint32_t
id_col,
- uint32_t num_rows_to_compare,
- const uint16_t*
sel_left_maybe_null,
- const uint32_t* left_to_right_map,
- LightContext* ctx, const
KeyColumnArray& col,
- const RowTableImpl& rows,
- uint8_t* match_bytevector);
+ static uint32_t NullUpdateColumnToRow_avx2(
+ bool use_selection, uint32_t id_col, uint32_t num_rows_to_compare,
+ const uint16_t* sel_left_maybe_null, const uint32_t* left_to_right_map,
+ LightContext* ctx, const KeyColumnArray& col, const RowTableImpl& rows,
+ uint8_t* match_bytevector, bool are_cols_in_encoding_order);
Review Comment:
Same here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
