laurentgo commented on PR #41533: URL: https://github.com/apache/arrow/pull/41533#issuecomment-2096607451
> We may want to optimize body of the noneMatch() call to use a case-insensitive TreeSet if this is called frequently (instead of searching linearly for each key as we're currently doing). I agree this is likely to be of greater benefit. I would argue that instead of using `TreeSet`, the original enum values could be stored in upper case (which is already the case but better safe than sorry) and instead convert each header to uppercase once as well and check the set. This is likely to avoid extra comparisons/case conversion to be done when navigating the tree. I also remember something about http/2 (used by gRPC) about headers possibly normalized as lower-case which (if true) could also be a better path for optimization -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
