jinchengchenghh commented on issue #28866: URL: https://github.com/apache/arrow/issues/28866#issuecomment-2097438161
No, now it just uses the binary serialized substrait as jni input. https://github.com/apache/arrow/blob/main/java/dataset/src/test/java/org/apache/arrow/dataset/substrait/TestAceroSubstraitConsumer.java#L176 HashMap is OK for most of the options, but the `CsvFragmentScanOptions` include other fields, I'm not sure if the ConvertOptions may have same config name with ReadOptions in the future. And ConvertOptions has complex config value like `std::unordered_map<std::string, std::shared_ptr<DataType>> column_types;` it should also be serialized, but we can support the basic option by `HashMap`, I'm not sure if their is requirement for the complex options in the future. What do you think? @westonpace https://github.com/apache/arrow/blob/main/cpp/src/arrow/dataset/file_csv.h#L85 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
