pitrou commented on code in PR #41565:
URL: https://github.com/apache/arrow/pull/41565#discussion_r1592591698
##########
cpp/src/parquet/encoding_test.cc:
##########
@@ -1383,7 +1383,7 @@ class TestByteStreamSplitEncoding : public
TestEncodingBase<Type> {
encoder->PutSpaced(draws_, num_values_, valid_bits, valid_bits_offset);
encode_buffer_ = encoder->FlushValues();
ASSERT_EQ(encode_buffer_->size(), physical_byte_width() * (num_values_ -
null_count));
- decoder->SetData(num_values_ - null_count, encode_buffer_->data(),
+ decoder->SetData(num_values_, encode_buffer_->data(),
Review Comment:
Ouch. Can we also improve the docstring for `Decoder::SetData`, to make it
clear that the `num_values` parameter also includes null values?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
