pitrou commented on code in PR #41346:
URL: https://github.com/apache/arrow/pull/41346#discussion_r1592679797
##########
cpp/src/parquet/column_reader.cc:
##########
@@ -1045,6 +1052,7 @@ class TypedColumnReaderImpl : public
TypedColumnReader<DType>,
// Not present for non-repeated fields
if (this->max_rep_level_ > 0 && rep_levels != nullptr) {
+ DCHECK_GT(this->max_rep_level_, 0);
int64_t num_rep_levels = this->ReadRepetitionLevels(batch_size,
rep_levels);
if (def_levels != nullptr && *num_def_levels != num_rep_levels) {
Review Comment:
Shouldn't this be `num_rep_levels != batch_size` instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
