WillAyd commented on PR #41487: URL: https://github.com/apache/arrow/pull/41487#issuecomment-2099459159
So I've added that but it flags a lot of issues in the current code base. What I have so far generates a clean build with the `ninja-debug` preset but there are still issues; guessing they come from full builds. I'm happy to clean those up as well just wanted to confirm it isn't too big of a change in its current state with you before continuing. Another possible issue is that the `-Wredundant-move` flag also gets applied to non-cpp files, yielding the following warnings during a build: ```sh [140/780] Building C object src/arrow/CMakeFiles/arrow_vendored.dir/vendored/musl/strptime.c.o cc1: warning: command-line option ‘-Wredundant-move’ is valid for C++/ObjC++ but not for C [147/780] Building C object src/arrow/CMakeFiles/arrow_vendored.dir/vendored/uriparser/UriIp4Base.c.o cc1: warning: command-line option ‘-Wredundant-move’ is valid for C++/ObjC++ but not for C [148/780] Building C object src/arrow/CMakeFiles/arrow_vendored.dir/vendored/uriparser/UriIp4.c.o cc1: warning: command-line option ‘-Wredundant-move’ is valid for C++/ObjC++ but not for C [149/780] Building C object src/arrow/CMakeFiles/arrow_vendored.dir/vendored/uriparser/UriMemory.c.o cc1: warning: command-line option ‘-Wredundant-move’ is valid for C++/ObjC++ but not for C [150/780] Building C object src/arrow/CMakeFiles/arrow_vendored.dir/vendored/uriparser/UriCompare.c.o cc1: warning: command-line option ‘-Wredundant-move’ is valid for C++/ObjC++ but not for C [151/780] Building C object src/arrow/CMakeFiles/arrow_vendored.dir/vendored/uriparser/UriCommon.c.o cc1: warning: command-line option ‘-Wredundant-move’ is valid for C++/ObjC++ but not for C [152/780] Building C object src/arrow/CMakeFiles/arrow_vendored.dir/vendored/uriparser/UriNormalizeBase.c.o cc1: warning: command-line option ‘-Wredundant-move’ is valid for C++/ObjC++ but not for C [153/780] Building C object src/arrow/CMakeFiles/arrow_vendored.dir/vendored/uriparser/UriParseBase.c.o cc1: warning: command-line option ‘-Wredundant-move’ is valid for C++/ObjC++ but not for C [154/780] Building C object src/arrow/CMakeFiles/arrow_vendored.dir/vendored/uriparser/UriEscape.c.o cc1: warning: command-line option ‘-Wredundant-move’ is valid for C++/ObjC++ but not for C [155/780] Building C object src/arrow/CMakeFiles/arrow_vendored.dir/vendored/uriparser/UriNormalize.c.o cc1: warning: command-line option ‘-Wredundant-move’ is valid for C++/ObjC++ but not for C [156/780] Building C object src/arrow/CMakeFiles/arrow_vendored.dir/vendored/uriparser/UriResolve.c.o cc1: warning: command-line option ‘-Wredundant-move’ is valid for C++/ObjC++ but not for C [157/780] Building C object src/arrow/CMakeFiles/arrow_vendored.dir/vendored/uriparser/UriShorten.c.o cc1: warning: command-line option ‘-Wredundant-move’ is valid for C++/ObjC++ but not for C [159/780] Building C object src/arrow/CMakeFiles/arrow_vendored.dir/vendored/uriparser/UriFile.c.o cc1: warning: command-line option ‘-Wredundant-move’ is valid for C++/ObjC++ but not for C [160/780] Building C object src/arrow/CMakeFiles/arrow_vendored.dir/vendored/uriparser/UriRecompose.c.o cc1: warning: command-line option ‘-Wredundant-move’ is valid for C++/ObjC++ but not for C [162/780] Building C object src/arrow/CMakeFiles/arrow_vendored.dir/vendored/uriparser/UriQuery.c.o cc1: warning: command-line option ‘-Wredundant-move’ is valid for C++/ObjC++ but not for C [164/780] Building C object src/arrow/CMakeFiles/arrow_vendored.dir/vendored/uriparser/UriParse.c.o cc1: warning: command-line option ‘-Wredundant-move’ is valid for C++/ObjC++ but not for C ``` I didn't quite where those flags were getting intermixed yet; something to investigate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
