tustvold commented on code in PR #5735:
URL: https://github.com/apache/arrow-rs/pull/5735#discussion_r1593474136
##########
arrow-data/src/byte_view.rs:
##########
@@ -32,6 +32,18 @@ pub struct ByteView {
}
impl ByteView {
+ /// Try to create a [`ByteView`] from the provided `v`
+ ///
+ /// If `v` instead contains the binary data inline, returns an `Err`
containing it
+ #[inline]
+ pub fn try_new(v: &u128) -> Result<Self, &[u8]> {
Review Comment:
The idea would then be that we would remove the `From<u128>` implementation,
which would be a breaking change but the next release is going to be breaking
anyway (and I suspect few people are relying on this API yet)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
