vertexclique commented on pull request #9495:
URL: https://github.com/apache/arrow/pull/9495#issuecomment-782885751


   > For my own understanding, could you give some insight into the ordering 
comments and the `spin_loop_hint`?
   
   loop hint is for waiting on the cpu without os intervention to wait until to 
the point of expected value for this test.
   
   > Note that this PR does no modify the ALLOCATIONS bit. That is the same as 
it was before. That was added in 2.0 and in the context of FFI; I measured no 
performance difference (maybe 2-3%).
   
   > The change set of this PR is essentially bf1a7eb
   
   I've just seen this, probably I wasn't the reviewer or simply missed the 
review cycle.
   I don't think that it can be seen in test execution. But it can be seen in 
the normal execution of the code. 
   Moreover, in the actual release code, it is not needed and can be filtered 
out.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to