alamb commented on PR #5619: URL: https://github.com/apache/arrow-rs/pull/5619#issuecomment-2100433097
> As it stands this feels like a touch premature, given it really just avoids encoding the number 12 in various places 😅 I updated the description of this PR to make the rationale clearer. While encoding the number 12 isn't a huge deal in my mind, the core rationale for this PR does is to reduce the cognative overhead of working with `ByteViewArrays`. Without an abstraction such as `View`, you have to remember what the `u128` represents and both its variants. While some people have the necessary time to invest understanding the lowest level representation, I think it is a barrier to contribution (as well as using the library). I have seen evidence of this challenge in a few examples such as https://github.com/apache/arrow-rs/pull/5557 to build up the `u128` from the parquet data pages as well as https://github.com/apache/arrow-rs/pull/5707#discussion_r1589974182 in https://github.com/apache/arrow-rs/pull/5707. While there might be other explanations, I think an abstraction like this will make ByteViewArrays much easier to work with -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
