ZhangHuiGui commented on code in PR #41194:
URL: https://github.com/apache/arrow/pull/41194#discussion_r1594084734
##########
cpp/src/arrow/compute/row/row_internal.h:
##########
@@ -165,7 +165,7 @@ class ARROW_EXPORT RowTableImpl {
/// \brief Initialize a row array for use
///
/// This must be called before any other method
- Status Init(MemoryPool* pool, const RowTableMetadata& metadata);
+ Status Init(MemoryPool* pool, const RowTableMetadata* metadata);
Review Comment:
> By the looks of it, the pointer needs to be non-null anyway...
You're right, we can prevent lots of unnecessary changes actually.
I previously wanted to unify the external access to metadata (all access
using pointers to maintain consistent const pointer semantics, but in fact it
is not necessary)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
