zeroshade commented on code in PR #41583:
URL: https://github.com/apache/arrow/pull/41583#discussion_r1594149095
##########
cpp/src/arrow/dataset/scanner.h:
##########
@@ -287,10 +290,12 @@ struct ARROW_DS_EXPORT ProjectionDescr {
/// \brief Create a default projection referencing fields in the dataset
schema
static Result<ProjectionDescr> FromNames(std::vector<std::string> names,
- const Schema& dataset_schema);
+ const Schema& dataset_schema,
+ bool add_augmented_fields);
Review Comment:
should we set a default value to ensure we don't break any existing
consumers of this function?
##########
cpp/src/arrow/dataset/scanner.h:
##########
@@ -287,10 +290,12 @@ struct ARROW_DS_EXPORT ProjectionDescr {
/// \brief Create a default projection referencing fields in the dataset
schema
static Result<ProjectionDescr> FromNames(std::vector<std::string> names,
- const Schema& dataset_schema);
+ const Schema& dataset_schema,
+ bool add_augmented_fields);
/// \brief Make a projection that projects every field in the dataset schema
- static Result<ProjectionDescr> Default(const Schema& dataset_schema);
+ static Result<ProjectionDescr> Default(const Schema& dataset_schema,
+ bool add_augmented_fields);
Review Comment:
same as above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
