zeroshade commented on code in PR #41595:
URL: https://github.com/apache/arrow/pull/41595#discussion_r1594508222
##########
go/arrow/csv/reader.go:
##########
@@ -982,7 +966,7 @@ func (c conversionColumn) inferType(v string)
arrow.DataType {
c.typ = arrow.FixedWidthTypes.Boolean
case *arrow.BooleanType:
c.typ = arrow.FixedWidthTypes.Date32
- case *arrow.Date32Type:
+ case *arrow.Date32Type, *arrow.Date64Type:
Review Comment:
The way the inferring works is essentially a loop that progressively tries
the next type in that switch case. since both Date32 and Date64 expect the data
to be in the same format it makes sense to only pick one for our inferring.
So the question is which one do we want the default inferred type to be when
it sees "YYYY-MM-DD" data? Date32 or Date64? whichever one we want the inferred
default to be, that's the one we leave in this switch (and should be what
`c.typ` is set to at line 968 above it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
