davidhcoe commented on PR #1821: URL: https://github.com/apache/arrow-adbc/pull/1821#issuecomment-2103408709
Overall, this is a good step toward a 1.1 implementation. I am not sure how we got the BulkIngest method in AdbcConnection, since the spec doesn't define that, but Java has it too, so we will need to clean that up at some point. The other part I don't know about is whether having SetOption(string, object) is sufficient to having the SetOptionByte, SetOptionInt, etc., methods that are defined in the spec. I see they are defined in the C importer/exporter, though, just not in the core C# definitions. I think this is largely because having different methods means having different dictionaries as well, which would seem strange to have to go look through different dictionaries to find where a value is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
