birschick-bq commented on code in PR #1849:
URL: https://github.com/apache/arrow-adbc/pull/1849#discussion_r1596112643
##########
csharp/src/Drivers/Apache/Hive2/HiveServer2Statement.cs:
##########
@@ -123,9 +138,23 @@ protected async ValueTask<Schema> GetSchemaAsync()
return SchemaParser.GetArrowSchema(response.Schema);
}
- protected internal int PollTimeMilliseconds { get; } =
PollTimeMillisecondsDefault;
+ protected internal int PollTimeMilliseconds { get; private set; } =
PollTimeMillisecondsDefault;
+
+ protected internal int BatchSize { get; private set; } =
BatchSizeDefault;
+
+ public static class StatementOptions
+ {
+ public const string PollTimeMilliseconds =
"adbc.statement.polltime_milliseconds";
Review Comment:
Not sure about the naming convention for these options. Should they be
simple, like `polltime_milliseconds` instead of including a "namespace"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
