vibhatha commented on code in PR #41601:
URL: https://github.com/apache/arrow/pull/41601#discussion_r1596136078
##########
java/vector/src/main/java/org/apache/arrow/vector/complex/BaseRepeatedValueVector.java:
##########
@@ -355,16 +355,12 @@ public int getInnerValueCountAt(int index) {
offsetBuffer.getInt(index * OFFSET_WIDTH);
}
- /** Return if value at index is null (this implementation is always false).
*/
+ /** Return if value at index is null. */
@Override
- public boolean isNull(int index) {
- return false;
- }
+ public abstract boolean isNull(int index);
Review Comment:
Yes that works better I guess.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]