kou commented on code in PR #41378:
URL: https://github.com/apache/arrow/pull/41378#discussion_r1596761043
##########
.github/workflows/python.yml:
##########
@@ -171,6 +171,23 @@ jobs:
with:
fetch-depth: 0
submodules: recursive
+ - name: Install ccache
+ run: brew install ccache
Review Comment:
We don't need this because `ccache` is installed by `brew bundle
--file=cpp/Brewfile`.
##########
.github/workflows/python.yml:
##########
@@ -171,6 +171,23 @@ jobs:
with:
fetch-depth: 0
submodules: recursive
+ - name: Install ccache
+ run: brew install ccache
+ - name: Display ccache statistics before build
+ run: ccache -s
Review Comment:
We don't need this because `ci/scripts/cpp_build.sh` has this.
##########
.github/workflows/python.yml:
##########
@@ -171,6 +171,23 @@ jobs:
with:
fetch-depth: 0
submodules: recursive
+ - name: Install ccache
+ run: brew install ccache
+ - name: Display ccache statistics before build
+ run: ccache -s
+ - name: Setup ccache
+ shell: bash
+ run: ci/scripts/ccache_setup.sh
+ - name: ccache info
+ id: ccache-info
+ shell: bash
+ run: echo "cache-dir=$(ccache --get-config cache_dir)" >>
$GITHUB_OUTPUT
+ - name: Cache ccache
+ uses: actions/cache@v4
+ with:
+ path: ${{ steps.ccache-info.outputs.cache-dir }}
+ key: python-ccache-macos-${{ matrix.macos-version }}-${{
hashFiles('cpp/**', 'python/**') }}
+ restore-keys: python-ccache-macos-${{ matrix.macos-version }}-
Review Comment:
Could you move this between `"Install Dependencies"` and `"Build"`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
