danepitkin commented on code in PR #458:
URL: https://github.com/apache/arrow-nanoarrow/pull/458#discussion_r1596943435
##########
python/src/nanoarrow/_lib.pyx:
##########
@@ -1717,6 +1717,13 @@ cdef class SchemaMetadata:
for key, _ in self.items():
yield key
+ def keys(self):
+ return list(self)
+
+ def values(self):
+ for _, value in self.items():
+ yield value
Review Comment:
Should we make `keys` and `values` return the same container type? Right now
one is a list and the other is a generator. Maybe use lists for both?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
