kou commented on code in PR #41487:
URL: https://github.com/apache/arrow/pull/41487#discussion_r1597565172
##########
cpp/src/arrow/util/iterator.h:
##########
@@ -180,9 +180,8 @@ class Iterator : public
util::EqualityComparable<Iterator<T>> {
ARROW_ASSIGN_OR_RAISE(auto element, maybe_element);
out.push_back(std::move(element));
}
- // ARROW-8193: On gcc-4.8 without the explicit move it tries to use the
- // copy constructor, which may be deleted on the elements of type T
- return std::move(out);
+
Review Comment:
```suggestion
```
##########
cpp/src/arrow/dataset/dataset_writer.cc:
##########
@@ -409,7 +409,7 @@ class DatasetWriterDirectoryQueue {
dir_queue->PrepareDirectory();
ARROW_ASSIGN_OR_RAISE(dir_queue->current_filename_,
dir_queue->GetNextFilename());
// std::move required to make RTools 3.5 mingw compiler happy
Review Comment:
Could you remove this comment?
##########
cpp/src/arrow/io/compressed.cc:
##########
@@ -413,7 +413,7 @@ class CompressedInputStream::Impl {
RETURN_NOT_OK(buf->Resize(bytes_read));
// Using std::move because some compiler might has issue below:
// https://wg21.cmeerw.net/cwg/issue1579
Review Comment:
Hmm. We may not be able to remove this `std::move()`:
https://github.com/apache/arrow/pull/39807
Let's try R jobs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
