tustvold commented on code in PR #5740:
URL: https://github.com/apache/arrow-rs/pull/5740#discussion_r1598281648
##########
arrow-cast/src/parse.rs:
##########
@@ -860,7 +860,7 @@ pub fn parse_decimal<T: DecimalType>(
"can't parse the string value {s} to decimal"
)));
}
- if fractionals == scale {
+ if fractionals == scale && scale != 0 {
Review Comment:
It took me quite a while to work out what was going on here, the issue
appears to be that parse_e_notation uses a non-zero fractionals to skip over
the decimal point.
I think this can now overflow, but I think that is a broader issue with the
e parsing logic. I will file a ticket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
