zanmato1984 commented on code in PR #41335:
URL: https://github.com/apache/arrow/pull/41335#discussion_r1598762503
##########
cpp/src/arrow/compute/key_hash_internal.h:
##########
@@ -48,6 +48,12 @@ class ARROW_EXPORT Hashing32 {
static void HashMultiColumn(const std::vector<KeyColumnArray>& cols,
LightContext* ctx,
uint32_t* out_hash);
+ // Clarify the max temp stack usage for HashBatch so the caller could
reserve enough
+ // size in advance.
Review Comment:
Sorry for the confusion. This comment along with the following constant is
because of the fact that `HashBatch` assumes an already-allocated stack rather
than having its own, so the caller (the stack owner) may need to know it
(possibly at compile time) in advance - otherwise the caller would have to be
aware of the full implementation of `HashBatch`, i.e. how much stack space is
used by `HashBatch`.
The case `HashBatchTempStackUsage` in the test is to prevent the
implementation of `HashBatch` from diverging from this constant.
The same idea applies to the rest of this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
