pitrou commented on a change in pull request #9542:
URL: https://github.com/apache/arrow/pull/9542#discussion_r580233975



##########
File path: cpp/src/arrow/flight/client.cc
##########
@@ -58,7 +58,7 @@
 #include "arrow/flight/serialization_internal.h"
 #include "arrow/flight/types.h"
 
-namespace pb = arrow::flight::protocol;
+namespace afpb = arrow::flight::protocol;

Review comment:
       What if you put the "namespace pb" alias inside the `arrow` namespace 
below?
   There is no reason to believe that top-level `afpb` won't conflict with 
another library.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to