jorisvandenbossche commented on code in PR #41494:
URL: https://github.com/apache/arrow/pull/41494#discussion_r1600366741
##########
python/setup.py:
##########
@@ -152,48 +152,27 @@ def initialize_options(self):
if not hasattr(sys, 'gettotalrefcount'):
self.build_type = 'release'
- self.with_azure = strtobool(
- os.environ.get('PYARROW_WITH_AZURE', '0'))
- self.with_gcs = strtobool(
- os.environ.get('PYARROW_WITH_GCS', '0'))
- self.with_s3 = strtobool(
- os.environ.get('PYARROW_WITH_S3', '0'))
- self.with_hdfs = strtobool(
- os.environ.get('PYARROW_WITH_HDFS', '0'))
- self.with_cuda = strtobool(
- os.environ.get('PYARROW_WITH_CUDA', '0'))
- self.with_substrait = strtobool(
- os.environ.get('PYARROW_WITH_SUBSTRAIT', '0'))
- self.with_flight = strtobool(
- os.environ.get('PYARROW_WITH_FLIGHT', '0'))
- self.with_acero = strtobool(
- os.environ.get('PYARROW_WITH_ACERO', '0'))
- self.with_dataset = strtobool(
- os.environ.get('PYARROW_WITH_DATASET', '0'))
- self.with_parquet = strtobool(
- os.environ.get('PYARROW_WITH_PARQUET', '0'))
- self.with_parquet_encryption = strtobool(
- os.environ.get('PYARROW_WITH_PARQUET_ENCRYPTION', '0'))
- self.with_orc = strtobool(
- os.environ.get('PYARROW_WITH_ORC', '0'))
- self.with_gandiva = strtobool(
- os.environ.get('PYARROW_WITH_GANDIVA', '0'))
+ self.with_azure = None
Review Comment:
Yes, they are still used in case someone is passing that to setup.py. See
https://github.com/apache/arrow/pull/41494#issuecomment-2092832830
I think that's something we should deprecate, though. But planning to do a
separate follow-up PR to that, since it's not actually related to this PR (it's
just another way that someone can right now override the default, just as
setting an environment variable)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
